Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove hardcode xcm config #1891

Merged
merged 11 commits into from
Oct 18, 2022
Merged

Conversation

mclyk
Copy link
Contributor

@mclyk mclyk commented Oct 10, 2022

close #1897

@mclyk mclyk force-pushed the chore/remove_hardcode_xcm_config branch from 0bb5370 to 5fe973c Compare October 11, 2022 01:53
@codecov-commenter
Copy link

Codecov Report

Base: 62.12% // Head: 62.05% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (c5ab830) compared to base (11e68d6).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
- Coverage   62.12%   62.05%   -0.08%     
==========================================
  Files         172      172              
  Lines       18563    18586      +23     
==========================================
  Hits        11533    11533              
- Misses       7030     7053      +23     
Impacted Files Coverage Δ
pallets/traits/src/xcm.rs 0.00% <0.00%> (ø)
runtime/heiko/src/lib.rs 0.00% <ø> (ø)
runtime/kerria/src/lib.rs 0.00% <ø> (ø)
runtime/parallel/src/lib.rs 0.00% <ø> (ø)
runtime/vanilla/src/lib.rs 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mclyk mclyk force-pushed the chore/remove_hardcode_xcm_config branch from c5ab830 to 15bbaf4 Compare October 11, 2022 08:01
@mclyk mclyk marked this pull request as ready for review October 13, 2022 09:14
@mclyk mclyk requested review from GopherJ and yrong and removed request for GopherJ October 13, 2022 09:14
@GopherJ
Copy link
Contributor

GopherJ commented Oct 18, 2022

@MrPai it'll be handy to add a command for adding new xcm asset using the four infos (unit per second can be calculated)

image

Ref: https://github.com/PureStake/xcm-tools

@mclyk
Copy link
Contributor Author

mclyk commented Oct 18, 2022

Sure, will add some off-chain scripts in the next PR to make it more convenient.

@mclyk mclyk merged commit 2b0e61e into master Oct 18, 2022
@mclyk mclyk deleted the chore/remove_hardcode_xcm_config branch October 18, 2022 04:30
@mclyk mclyk mentioned this pull request Nov 5, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssetRegistry: xcmLocationConfig and unitFeePerSecond
3 participants