-
Notifications
You must be signed in to change notification settings - Fork 2
Updated pchain_client_cli related commands in docs #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments.
|
||
Upon first use of `pchain_client`, you will be prompted to set up a password to protect your account keypairs. Please note that this password can be different from the password you used in ParallelChain Explorer. Alternatively, you can skip the password protection by simply pressing Enter. | ||
|
||
To check if `pchain_client` is intalled properly, run the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: installed spelling.
@@ -49,10 +49,11 @@ Here are some CLI subcommands to indicate corresponding Protocol Transaction Com | |||
``` | |||
|
|||
|
|||
First, provide the following 4 parameters: | |||
First, decide the version of the transaction that you are creating with the flags `--v1` and `--v2`, then provide the following 4 parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 5 params now instead of 4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was thinking if the "parameters" are referring to the fields in <>?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah my bad, now I get what you mean - setting the flag (v1 | v2), and then setting the 4 other params. Further down it seemed like the two terms are used interchangeably: with the flag --destination
, so maybe could be a a little clearer?
--v1
and--v2
tags inpchain_client transaction create
andpchain_client parse contract_address
commands--name
to--keypair-name
forpchain_client keys
commands