Skip to content

Updated pchain_client_cli related commands in docs #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

manngayin612
Copy link
Contributor

  • Added --v1 and --v2 tags in pchain_client transaction create and pchain_client parse contract_address commands
  • Renamed --name to --keypair-name for pchain_client keys commands
  • general rephrase

@manngayin612 manngayin612 requested a review from cy6581 December 19, 2023 04:13
Copy link

github-actions bot commented Dec 19, 2023

PR Preview Action v1.4.6
🚀 Deployed preview to https://parallelchain-io.github.io/parallelchain-docs/pr-preview/pr-15/
on branch gh-pages at 2023-12-20 03:17 UTC

Copy link

@cy6581 cy6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments.


Upon first use of `pchain_client`, you will be prompted to set up a password to protect your account keypairs. Please note that this password can be different from the password you used in ParallelChain Explorer. Alternatively, you can skip the password protection by simply pressing Enter.

To check if `pchain_client` is intalled properly, run the following command:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: installed spelling.

@@ -49,10 +49,11 @@ Here are some CLI subcommands to indicate corresponding Protocol Transaction Com
```


First, provide the following 4 parameters:
First, decide the version of the transaction that you are creating with the flags `--v1` and `--v2`, then provide the following 4 parameters:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 5 params now instead of 4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was thinking if the "parameters" are referring to the fields in <>?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah my bad, now I get what you mean - setting the flag (v1 | v2), and then setting the 4 other params. Further down it seemed like the two terms are used interchangeably: with the flag --destination, so maybe could be a a little clearer?

@manngayin612 manngayin612 requested a review from cy6581 January 22, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants