refactor(commands): force discover command to include product manager rules

[janhesters]

This PR Migrates the /discover command to include the full Product Manager sudolang program instead of recursively calling its rules. This improves prompt adherence and accuracy when running the command.

Unlike other migrations from rules to slash commands, the Product Manager rules are not deleted in this PR, since they can still be leveraged contextually by the Cursor editor when needed.

---

Note

Inlines the full Product Manager spec into ai/commands/discover.md, adding entity/type definitions, CRUD operations, command interface, and updated discovery constraints.

• Discover command overhaul:
  • Replaces reference to productmanager.mdc with an inline, full Product Manager spec in ai/commands/discover.md.
• Data model and types:
  • Defines Persona, Mockup, PainPoint (with impact/frequency), UserStory (priority formula), Step, UserJourney, FeaturePRD, StoryMap, Project, plus supporting types and Status.
• Operations and flow:
  • Adds CrudOperations for account, project, persona, painPoint, mockup, journey, step, story.
  • Introduces fn discover() outlining the discovery flow and constraints.
• Interface:
  • Specifies commands: /discover, /research, /setup, /generate [persona|journey|storymaps|userStories|feature], /feature, /save, /cancel [story].
• Constraints:
  • Updates guidance to plan a user journey when no plan exists and to respect please.mdc.

^{Written by Cursor Bugbot for commit eb77293. This will update automatically on new commits. Configure here.}

[ericelliott]

@cursor 🙏 review

[cursor]

🔬 Code Review Complete

I've completed a thorough review of the PR changes. Here's my assessment:

✅ Strengths

1. Migration Successfully Executed: The PR successfully embeds the full Product Manager SudoLang program directly into discover.md, eliminating recursive rule loading which improves prompt adherence.

2. Content Accuracy: The embedded content is an accurate copy of productmanager.mdc with the appropriate additions:

   • Added discover() function wrapper (lines 97-100)
   • Added /discover command to Interface section (line 103)
   • Properly calls /discover() at the end (line 112)

3. Proper Preservation: As stated in the PR description, productmanager.mdc is correctly retained for contextual use by the Cursor editor.

⚠️ Minor Inconsistencies

1. Header Format Deviation: The new file uses inconsistent formatting compared to other command files:

   • Other commands (log.md, commit.md): Use ## 📝 Log format (level 2 header with emoji)
   • New discover.md: Uses # Discover format (level 1 header, no emoji)

   Recommendation: Consider updating to ## 🔍 Discover for consistency with other command files.

2. Reference in please.mdc: Line 35 of please.mdc still says "use productmanager.mdc" which is now technically inaccurate since the command embeds the full program. However, this may be intentional for documentation purposes.

📋 Technical Correctness

• ✅ All type definitions properly copied
• ✅ Data structures intact (Persona, UserStory, PainPoint, etc.)
• ✅ Interface commands complete
• ✅ Constraints properly maintained
• ✅ Function logic preserved

🎯 Verdict

APPROVED - This PR successfully achieves its stated goal of forcing the discover command to include product manager rules instead of recursively calling them. The changes are clean, functional, and will improve prompt adherence as intended.

The minor header inconsistency is a stylistic concern and doesn't affect functionality. The core refactoring is sound and ready to merge.

---

 

_{Learn more about Cursor Agents}

[Copilot]

Pull Request Overview

This PR embeds the full Product Manager sudolang program directly into the /discover command to improve prompt adherence and accuracy, replacing the prior indirection to external rules.

• Inlines domain model (Personas, PainPoints, UserStories, Journeys, PRDs) and constraints into ai/commands/discover.md
• Defines command interface and CRUD semantics for discovery-related entities
• Provides a discover() entrypoint aligned with the new in-file constraints

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[ericelliott]

@janhesters I made a couple minor bug fixes that may need to be backported to the rule version... but also - this feels problematic. I don't want to maintain two identical files - one in commands, and one in rules - especially considering that I have not had much trouble getting the /command to work as-is. Thoughts? cc @cursor

[ericelliott]

I think we need to talk about this.

[janhesters]

@ericelliott Let's talk on Tuesday 👍