-
Notifications
You must be signed in to change notification settings - Fork 2
refactor(commands): migrate execute sudolang program to slash command #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@cursor 🙏 review |
🔬 Code ReviewI've completed a thorough review of the PR "refactor(commands): migrate execute sudolang program to slash command". Here are my findings: Summary of Changes
🚨 Critical Issues1. Misalignment Between Command Structure and Implementation The PR creates a structural inconsistency:
📋 RecommendationsOption A: Merge into Single
Option B: Separate Planning and Execution (More Granular)
My Recommendation: Option A is preferable because:
✅ What's Working Well
🎯 Action ItemsRequired:
Nice to have: ConclusionThe refactoring direction is sound, but the execution is incomplete. The command structure needs clarification before merging. I recommend Option A (merge into Would you like me to implement Option A or Option B to complete this refactoring? Learn more about Cursor Agents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the task execution workflow by migrating content from a rule file to a slash command. The content from task-creator.mdc has been moved to ai/commands/execute.md, transforming it from an always-applicable rule into an explicit command that users invoke.
Key Changes:
- Removed the entire
task-creator.mdcrule file - Replaced minimal command documentation in
execute.mdwith full task creator implementation - Changed from automatic rule application to explicit command invocation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ai/rules/task-creator.mdc | Completely removed the task creator rule file and all its content |
| ai/commands/execute.md | Replaced brief command description with full task creator implementation from the deleted rule file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ai/commands/execute.md
Outdated
| Commands { | ||
| /help | ||
| /task - create a task/epic | ||
| /list [(tasks|epics) = tasks]- list all tasks in the epic |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space before the dash in command description. Should be '/list [(tasks|epics) = tasks] - list all tasks in the epic'.
|
🧩 Refactor Request: Split Task Creator into Two Slash Commands Hey @cursor 👋 Let’s implement Option B (separate planning and execution) from your review summary. ✅ GoalSplit the Sudolang Task Creator program into two slash commands:
🧱 Required Changes1. File Structure
2. Command Declarations
3. Update
4. Code Adjustments
🧭 Acceptance Criteria
|
ai/commands/execute.md
Outdated
| Commands { | ||
| /help | ||
| /task - create a task/epic | ||
| /list [(tasks|epics) = tasks]- list all tasks in the epic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I'm good with separating /task and /execute - in fact, /execute feels like the wrong word. maybe /run [task] ? |
d6ac04c to
a06b885
Compare
Done 👍 |
We might want to put this as
/taskinstead.I think even better would be to separate the slash commands. One for the
/taskpart of the task creator, and one for the/executecommand. WDYT?Note
Moves the Task Creator guide from
ai/rules/task-creator.mdcintoai/commands/execute.md, expanding it and deleting the original rules file.ai/commands/execute.md: Replaces minimal execute doc with a full Task Creator guide, including Context Gathering, Requirements Analysis, Agent Orchestration, Task Planning, Execution Protocol, Task Plan Template, Completed Epic docs, Constraints,createTaskpipeline, and Commands (/help,/task,/list).ai/rules/task-creator.mdc(content migrated).Written by Cursor Bugbot for commit d6ac04c. This will update automatically on new commits. Configure here.