-
Notifications
You must be signed in to change notification settings - Fork 2
feat(commands): add brainstorm slash command #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@cursor 🙏 review |
🔬 Code ReviewI've completed a thorough review of the brainstorm slash command PR. Here's my analysis: ✅ Strengths
📋 Structural ObservationsConsistency with Project Patterns:
🔍 Detailed FindingsIssue 1: Missing Reference to
|
| Category | Score | Notes |
|---|---|---|
| Clarity | 9/10 | Clear purpose and structure |
| Completeness | 8/10 | Missing please.mdc reference |
| Consistency | 7/10 | Minor inconsistencies with other commands |
| Utility | 10/10 | Highly useful command for ideation |
| Safety | 10/10 | Appropriate safety constraints |
✅ Approval Status: APPROVED with Minor Suggestions
This is a valuable addition to the command set. The command is well-structured and will be immediately useful. The issues identified are minor and can be addressed in a follow-up if desired.
🎯 Recommended Actions (Optional)
- Add "Before beginning, read and respect the constraints in please.mdc." to Constraints block
- Consider clarifying the web search and option-listing guidance for better consistency
- No blocking issues - safe to merge as-is
Summary: The brainstorm command is well-designed and ready for use. It follows project conventions and provides clear guidance for ideation workflows. The minor inconsistencies noted don't block the PR but could improve consistency if addressed.
Learn more about Cursor Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new /brainstorm slash command that provides an AI-powered brainstorming assistant for software development solutions. The command is designed to help users ideate solutions with clear trade-offs and recommendations.
- Adds a structured brainstorming command with defined roles (mentor, advisor)
- Implements constraints emphasizing edge cases, scalability, maintainability, and user safety
- Includes guidance for unbiased option listing followed by recommendations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@ericelliott I would ignore both of @cursor's suggestions:
This will just create circular references.
I want to keep it vague to get the agent to use it's best judgement when to look up things. You can always explicitly tell it what to look up in your prompt, e.g. |
ai/commands/brainstorm.md
Outdated
| Goal: help the user ideate solutions with clear trade-offs and a final recommendation. | ||
|
|
||
| Brainstorm { | ||
| currentYear: 2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't hard-code current dates. Instead, we COULD add an instruction to grab the current date with a tool call to please.mdc, and then it will be in context when the user types please /[command] - including this one.
I wonder if "memoizedLookup(date)" would do the trick here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
4003e4e to
8473502
Compare
This is another slash command I use a ton. It helps to quickly (or slowly and deliberately depending on the context) brainstorm approaches.