Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proper background color on sticky table header #1329

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Set proper background color on sticky table header #1329

merged 3 commits into from
Nov 22, 2024

Conversation

rolfheij-sil
Copy link
Contributor

@rolfheij-sil rolfheij-sil commented Nov 21, 2024 •
edited
Loading

This change is Reviewable

@rolfheij-sil rolfheij-sil marked this pull request as ready for review November 22, 2024 09:18
@rolfheij-sil rolfheij-sil changed the title (Attempt to) make sticky header non-transparent Set proper background color on sticky table header Nov 22, 2024
tjcouch-sil
tjcouch-sil approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks!

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@rolfheij-sil rolfheij-sil merged commit d93ffde into main Nov 22, 2024
7 checks passed
@rolfheij-sil rolfheij-sil deleted the fix-table-header-bleed-through branch November 22, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjcouch-sil tjcouch-sil tjcouch-sil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolfheij-sil @tjcouch-sil