Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intensify secondary color in platform theme #1360

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

Sebastian-ubs
Copy link
Contributor

@Sebastian-ubs Sebastian-ubs commented Nov 29, 2024

fixes https://github.com/paranext/ux/issues/201

Actual code change is 1 number, the rest is examples and build

before:
Screenshot 2024-11-29 114142

after:
Screenshot 2024-11-29 114109


This change is Reviewable

@Sebastian-ubs Sebastian-ubs enabled auto-merge (squash) November 29, 2024 10:48
Copy link
Contributor

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks for the highlight improvement and the examples

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Sebastian-ubs Sebastian-ubs merged commit aa56476 into main Dec 1, 2024
7 checks passed
@Sebastian-ubs Sebastian-ubs deleted the 201-change-inactive-text-selection-color branch December 1, 2024 19:17
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Sebastian-ubs)


lib/platform-bible-react/src/index.css line 13 at r1 (raw file):

}

/* #region shared with https://github.com/paranext/paranext-extension-template/blob/main/tailwind.css */

Thanks for the update! Could you please also make this change in the template tailwind.css?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants