Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stacktraces #276

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Fix stacktraces #276

merged 2 commits into from
Jul 17, 2018

Conversation

aronisstav
Copy link
Member

@aronisstav aronisstav commented Jul 16, 2018

Summary

The patch c95c2c6 made it possible for stacktraces to linger and be reported when they were irrelevant. This patch fixes this.

Fixes aronisstav#42.

Checklist

  • Has tests (or doesn't need them)
  • Updates CHANGELOG (or too minor)
  • References related Issues

@codecov
Copy link

codecov bot commented Jul 16, 2018

Codecov Report

Merging #276 into master will increase coverage by <.01%.
The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage    94.2%   94.21%   +<.01%     
==========================================
  Files          12       12              
  Lines        3575     3580       +5     
==========================================
+ Hits         3368     3373       +5     
  Misses        207      207
Flag Coverage Δ
#tests 93.88% <82.75%> (ø) ⬆️
#tests_real 84.38% <72.41%> (-0.01%) ⬇️
#unit_tests 2.54% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/concuerror_callback.erl 92.61% <80%> (+0.07%) ⬆️
src/concuerror_inspect.erl 91.89% <88.88%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee55c3...0911ab7. Read the comment docs.

@aronisstav aronisstav merged commit 3ae22f4 into parapluu:master Jul 17, 2018
@aronisstav aronisstav deleted the fix-stacktrace branch July 17, 2018 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacktraces are wrong once again...
1 participant