Check for updates at startup #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switches from async client to threaded client - Removes about a bajillion dependencies - Fixes persistence to show update notifications on startup
|
The persistence was updated to save the release notes and update URL so that update notifications can be provided at startup without hitting GitHub's API. This fixes the unusual behavior described above. I also replaced the async |
- The timer was always using its own duration, ignoring the timestamp persisted from previous runs.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large change that adds a simple periodic update check. It defaults to disabled (so the app doesn't require internet access).
The app will remember the last time it checked for updates, and also the last version it knows about. There is unusual behavior with this; If the app is closed while there is an update notification and the app is not updated, the persistence will cause the app to not show an update until another version is released. I might want to change this so the last known version is only persisted when the update notification is dismissed. But I also like that dismissal currently doesn't remove the notification from the GUI.