Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add present mode setters on Pixels #373

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

Kanabenki
Copy link
Contributor

Closes #372.

Add set_present_mode and enable_vsync methods on Pixels. The documentation is almost identical to the corresponding methods on PixelsBuilder since they do the same thing but after the instance has been created.

Copy link
Owner

@parasyte parasyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Do you think you would ever want a getter for the present mode? It could save the caller from maintaining that state (since Pixels already stores it) and it's just a one-liner. All good if you don't think it's useful.

@Kanabenki
Copy link
Contributor Author

Good idea, added that!

Copy link
Owner

@parasyte parasyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@parasyte parasyte merged commit 705f22b into parasyte:main Aug 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No possibility of changing the surface PresentMode without recreating the whole Pixels instance
2 participants