Improved regular expression for data-sets when functional flag is used. #914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have problems with the function flag and data providers.
1st Problem
I have tests with more than 10 data sets and numeric keys.
The regex as it is generated now does not properly filter the test for the wrapper.
This leads to strange results on the cli.
I have fixed it by using dataSetAsString and removed the willdcards from the regex.
2nd Problem
Some tests are using the class name as key for the data-provider.
The regex is not properly escaped for class names.
I fixed it using preg_quote.
I tried to reflect the problem in the unit test adjustments. Without the SuiteLoader adjustments the tests will fail.
Manually tested only with PHP 8.3.