Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cgroup v2 #23

Closed
kakkoyun opened this issue Sep 2, 2021 · 0 comments · Fixed by #178
Closed

Add support for cgroup v2 #23

kakkoyun opened this issue Sep 2, 2021 · 0 comments · Fixed by #178
Labels
enhancement New feature or request

Comments

@kakkoyun
Copy link
Member

kakkoyun commented Sep 2, 2021

parca-agent supports only cgroup v1 right now. The systemd already started supporting v2.

Kubernetes changes are in the pipeline (kubernetes/kubernetes#85218 & kubernetes/enhancements#2254).

@kakkoyun kakkoyun added the enhancement New feature or request label Sep 2, 2021
derekparker added a commit to derekparker/parca-agent that referenced this issue Dec 16, 2021
This patch adds support for the cgroups v2 unified filesystem. We now
attempt to detect at runtime which version of cgroup the host is using
and adapt appropriately.

Additionally this patch adds a small sanity check test for the profiler.
For now it only asserts that we have indeed received some profiling
sample data, in the future we can add more assertions.

Fixes parca-dev#23
derekparker added a commit to derekparker/parca-agent that referenced this issue Dec 16, 2021
This patch adds support for the cgroups v2 unified filesystem. We now
attempt to detect at runtime which version of cgroup the host is using
and adapt appropriately.

Additionally this patch adds a small sanity check test for the profiler.
For now it only asserts that we have indeed received some profiling
sample data, in the future we can add more assertions.

Fixes parca-dev#23
derekparker added a commit to derekparker/parca-agent that referenced this issue Dec 16, 2021
This patch adds support for the cgroups v2 unified filesystem. We now
attempt to detect at runtime which version of cgroup the host is using
and adapt appropriately.

Additionally this patch adds a small sanity check test for the profiler.
For now it only asserts that we have indeed received some profiling
sample data, in the future we can add more assertions.

Fixes parca-dev#23
derekparker added a commit to derekparker/parca-agent that referenced this issue Dec 16, 2021
This patch adds support for the cgroups v2 unified filesystem. We now
attempt to detect at runtime which version of cgroup the host is using
and adapt appropriately.

Additionally this patch adds a small sanity check test for the profiler.
For now it only asserts that we have indeed received some profiling
sample data, in the future we can add more assertions.

Fixes parca-dev#23
derekparker added a commit to derekparker/parca-agent that referenced this issue Dec 20, 2021
With cgroup v2 the perf_events controller is implicitly enabled so we
don't have to do anything manually from the perspective of the
parca-agent.

Fixes parca-dev#23
derekparker added a commit to derekparker/parca-agent that referenced this issue Dec 20, 2021
With cgroup v2 the perf_events controller is implicitly enabled so we
don't have to do anything manually from the perspective of the
parca-agent.

Fixes parca-dev#23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant