Remove navigateTo from useURLState's dependencies

parca-dev · May 25, 2023 · d9cfb97 · d9cfb97
1 parent 905286b
commit d9cfb97
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/ui/packages/shared/components/src/hooks/useURLState.tsx b/ui/packages/shared/components/src/hooks/useURLState.tsx
@@ -73,7 +73,7 @@ export const useURLState = ({
       }
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [value, highlightAfterFilteringEnabled, param, withURLUpdate, navigateTo]);
+  }, [value, highlightAfterFilteringEnabled, param, withURLUpdate]);
 
   if (param === 'dashboard_items') {
     let dashboardItems: string[] = [];

diff --git a/ui/packages/shared/profile/src/ProfileView/index.tsx b/ui/packages/shared/profile/src/ProfileView/index.tsx
@@ -133,12 +133,10 @@ export const ProfileView = ({
 
   const {loader, perf} = useParcaContext();
 
-  // TODO: Figure out why profileSource's constantly changing value causes an infinite render on PSC, thereby causing the instant reset bug in the icicle graph as reported in https://github.com/polarsignals/polarsignals/issues/1991#event-9340441410
-
-  // useEffect(() => {
-  //   // Reset the current path when the profile source changes
-  //   setCurPath([]);
-  // }, [profileSource]);
+  useEffect(() => {
+    // Reset the current path when the profile source changes
+    setCurPath([]);
+  }, [profileSource]);
 
   useEffect(() => {
     async function loadGraphviz(): Promise<void> {