Pnpm migration (#4566)

* Transpiling parser pkg * Move from yarn to pnpm package manager * React packages version fixed * Github actions and docs migration * Moved the setup-pnpm action to use the commit id instead of version * Synced the lock file * Build failure fixed * Fixed missing dependencies * Type check and lint errors fixed * Changed the workflow order to run typecheck before lint as that shows more useful errors earlier * Storybook build fixed * Use version from env vars Co-authored-by: Maxime Brunet <max@brnt.mx> * Updated github workflows to use pnpm version from env vars * Lockfile synced --------- Co-authored-by: Maxime Brunet <max@brnt.mx>
parca-dev · May 1, 2024 · e1be2a7 · e1be2a7
1 parent 28b15f3
commit e1be2a7
Show file tree

Hide file tree

Showing 41 changed files with 26,840 additions and 25,479 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -19,7 +19,7 @@
 /pkg/symbolizer    @parca-dev/agent-maintainers
 
 package.json
-yarn.lock
+pnpm-lock.yaml
 /go.mod
 /go.sum
 Dockerfile*

diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml
@@ -22,6 +22,8 @@ env:
   QEMU_VERSION: 7.0.0-7
   # renovate: datasource=docker depName=docker.io/buildpack-deps versioning=ubuntu
   BUILDPACK_DEPS_VERSION: '22.04'
+  # renovate: datasource=npm depName=pnpm versioning=npm
+  PNPM_VERSION: '9.0.6'
 
 jobs:
   build-and-test-multi-arch:
@@ -61,13 +63,17 @@ jobs:
       with:
         go-version-file: .go-version
 
+    - uses: pnpm/action-setup@a3252b78c470c02df07e9d59298aecedc3ccdd6d # v3.0.0
+      with:
+        version: ${{ env.PNPM_VERSION }}
+
     - name: Set up Node.js
       if: ${{ steps.skip-check.outputs.should_skip != 'true' && matrix.arch == 'amd64' }}
       uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
       with:
         node-version-file: .node-version
-        cache: 'yarn'
-        cache-dependency-path: ui/yarn.lock
+        cache: 'pnpm'
+        cache-dependency-path: ui/pnpm-lock.yaml
 
     - name: Build
       if: ${{ steps.skip-check.outputs.should_skip != 'true' && matrix.arch == 'amd64' }}

diff --git a/.github/workflows/chromatic.yml b/.github/workflows/chromatic.yml
@@ -21,6 +21,10 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.event.number || github.ref }}
   cancel-in-progress: true
 
+env:
+  # renovate: datasource=npm depName=pnpm versioning=npm
+  PNPM_VERSION: '9.0.6'
+
 # List of jobs
 jobs:
   skip-check:
@@ -57,13 +61,17 @@ jobs:
       - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
         with:
           fetch-depth: 0 # Required to retrieve git history
+      - uses: pnpm/action-setup@a3252b78c470c02df07e9d59298aecedc3ccdd6d # v3.0.0
+        with:
+          version: ${{ env.PNPM_VERSION }}
       - name: Set up Node.js
         uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
         with:
           node-version-file: .node-version
-          cache: 'yarn'
+          cache: 'pnpm'
+          cache-dependency-path: ui/pnpm-lock.yaml
       - name: Install dependencies and build app
-        run: yarn install --frozen-lockfile --prefer-offline && yarn build
+        run: pnpm install --frozen-lockfile --prefer-offline && pnpm run build
         # 👇 Adds Chromatic as a step in the workflow
       - name: Publish to Chromatic
         uses: chromaui/action@3dcb6636a4f8eed347ef6214f5d74d2b5fee45e4 # v11.3.0

diff --git a/.github/workflows/codeql-analysis-go.yml b/.github/workflows/codeql-analysis-go.yml
@@ -19,6 +19,10 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.event.number || github.ref }}
   cancel-in-progress: true
 
+env:
+  # renovate: datasource=npm depName=pnpm versioning=npm
+  PNPM_VERSION: '9.0.6'
+
 jobs:
   skip-check:
     name: Skip check
@@ -69,12 +73,16 @@ jobs:
         with:
           go-version-file: .go-version
 
+      - uses: pnpm/action-setup@a3252b78c470c02df07e9d59298aecedc3ccdd6d # v3.0.0
+        with:
+          version: ${{ env.PNPM_VERSION }}
+
       - name: Set up Node.js
         uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
         with:
           node-version-file: .node-version
-          cache: 'yarn'
-          cache-dependency-path: ui/yarn.lock
+          cache: 'pnpm'
+          cache-dependency-path: ui/pnpm-lock.yaml
 
       - name: Initialize CodeQL
         uses: github/codeql-action/init@d39d31e687223d841ef683f52467bd88e9b21c14 # v3.25.3

diff --git a/.github/workflows/container.yml b/.github/workflows/container.yml
@@ -20,6 +20,8 @@ concurrency:
 env:
   # renovate: datasource=go depName=github.com/goreleaser/goreleaser
   GORELEASER_VERSION: v1.25.1
+  # renovate: datasource=npm depName=pnpm versioning=npm
+  PNPM_VERSION: '9.0.6'
 
 jobs:
   skip-check:
@@ -74,12 +76,16 @@ jobs:
         with:
           go-version-file: .go-version
 
+      - uses: pnpm/action-setup@a3252b78c470c02df07e9d59298aecedc3ccdd6d # v3.0.0
+        with:
+          version: ${{ env.PNPM_VERSION }}
+
       - name: Set up Node.js
         uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
         with:
           node-version-file: .node-version
-          cache: 'yarn'
-          cache-dependency-path: ui/yarn.lock
+          cache: 'pnpm'
+          cache-dependency-path: ui/pnpm-lock.yaml
 
       - name: Set Tag
         run: |

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -17,6 +17,10 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.event.number || github.ref }}
   cancel-in-progress: true
 
+env:
+  # renovate: datasource=npm depName=pnpm versioning=npm
+  PNPM_VERSION: '9.0.6'
+
 jobs:
   skip-check:
     name: Skip check
@@ -58,12 +62,16 @@ jobs:
         with:
           go-version-file: .go-version
 
+      - uses: pnpm/action-setup@a3252b78c470c02df07e9d59298aecedc3ccdd6d # v3.0.0
+        with:
+          version: ${{ env.PNPM_VERSION }}
+
       - name: Set up Node.js
         uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
         with:
           node-version-file: .node-version
-          cache: 'yarn'
-          cache-dependency-path: ui/yarn.lock
+          cache: 'pnpm'
+          cache-dependency-path: ui/pnpm-lock.yaml
 
       - name: Docs check
         run: |

diff --git a/.github/workflows/go-lint.yml b/.github/workflows/go-lint.yml
@@ -18,6 +18,10 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.event.number || github.ref }}
   cancel-in-progress: true
 
+env:
+  # renovate: datasource=npm depName=pnpm versioning=npm
+  PNPM_VERSION: '9.0.6'
+
 jobs:
   skip-check:
     name: Skip check
@@ -63,12 +67,16 @@ jobs:
         run: |
           ./env.sh
 
+      - uses: pnpm/action-setup@a3252b78c470c02df07e9d59298aecedc3ccdd6d # v3.0.0
+        with:
+          version: ${{ env.PNPM_VERSION }}
+
       - name: Set up Node.js
         uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
         with:
           node-version-file: .node-version
-          cache: 'yarn'
-          cache-dependency-path: ui/yarn.lock
+          cache: 'pnpm'
+          cache-dependency-path: ui/pnpm-lock.yaml
 
       - name: Build UI
         run: make ui/build

diff --git a/.github/workflows/release-dry-run.yml b/.github/workflows/release-dry-run.yml
@@ -20,6 +20,8 @@ concurrency:
 env:
   # renovate: datasource=go depName=github.com/goreleaser/goreleaser
   GORELEASER_VERSION: v1.25.1
+  # renovate: datasource=npm depName=pnpm versioning=npm
+  PNPM_VERSION: '9.0.6'
 
 permissions:
   contents: write
@@ -81,12 +83,16 @@ jobs:
         with:
           go-version-file: .go-version
 
+      - uses: pnpm/action-setup@a3252b78c470c02df07e9d59298aecedc3ccdd6d # v3.0.0
+        with:
+          version: ${{ env.PNPM_VERSION }}
+
       - name: Set up Node.js
         uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
         with:
           node-version-file: .node-version
-          cache: 'yarn'
-          cache-dependency-path: ui/yarn.lock
+          cache: 'pnpm'
+          cache-dependency-path: ui/pnpm-lock.yaml
 
       - name: Set up Snapcraft
         run: |

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -12,6 +12,8 @@ concurrency:
 env:
   # renovate: datasource=go depName=github.com/goreleaser/goreleaser
   GORELEASER_VERSION: v1.25.1
+  # renovate: datasource=npm depName=pnpm versioning=npm
+  PNPM_VERSION: '9.0.6'
 
 permissions:
   contents: write
@@ -37,12 +39,16 @@ jobs:
         with:
           go-version-file: .go-version
 
+      - uses: pnpm/action-setup@a3252b78c470c02df07e9d59298aecedc3ccdd6d # v3.0.0
+        with:
+          version: ${{ env.PNPM_VERSION }}
+
       - name: Set up Node.js
         uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
         with:
           node-version-file: .node-version
-          cache: 'yarn'
-          cache-dependency-path: ui/yarn.lock
+          cache: 'pnpm'
+          cache-dependency-path: ui/pnpm-lock.yaml
 
       - name: Set up Snapcraft
         run: |

diff --git a/.github/workflows/snap.yml b/.github/workflows/snap.yml
@@ -20,6 +20,8 @@ concurrency:
 env:
   # renovate: datasource=go depName=github.com/goreleaser/goreleaser
   GORELEASER_VERSION: v1.25.1
+  # renovate: datasource=npm depName=pnpm versioning=npm
+  PNPM_VERSION: '9.0.6'
 
 permissions:
   contents: write
@@ -84,12 +86,16 @@ jobs:
           check-latest: true
           cache: true
 
+      - uses: pnpm/action-setup@a3252b78c470c02df07e9d59298aecedc3ccdd6d # v3.0.0
+        with:
+          version: ${{ env.PNPM_VERSION }}
+
       - name: Set up Node.js
         uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
         with:
           node-version-file: .node-version
-          cache: 'yarn'
-          cache-dependency-path: ui/yarn.lock
+          cache: 'pnpm'
+          cache-dependency-path: ui/pnpm-lock.yaml
 
       - name: Set up Snapcraft
         run: |

diff --git a/.github/workflows/ui-publish-components.yml b/.github/workflows/ui-publish-components.yml
@@ -9,6 +9,10 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.event.number || github.ref }}
   cancel-in-progress: false
 
+env:
+  # renovate: datasource=npm depName=pnpm versioning=npm
+  PNPM_VERSION: '9.0.6'
+
 jobs:
   skip-check:
     name: Skip check
@@ -52,12 +56,16 @@ jobs:
           git fetch origin +refs/heads/main:refs/remotes/origin/main && \
           git checkout main
 
+      - uses: pnpm/action-setup@a3252b78c470c02df07e9d59298aecedc3ccdd6d # v3.0.0
+        with:
+          version: ${{ env.PNPM_VERSION }}
+
       - name: Set up Node.js
         uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
         with:
           node-version-file: .node-version
-          cache: 'yarn'
-          cache-dependency-path: ui/yarn.lock
+          cache: 'pnpm'
+          cache-dependency-path: ui/pnpm-lock.yaml
 
       - name: Ensure access
         working-directory: ui
@@ -71,16 +79,16 @@ jobs:
           git config --global user.name "${{ github.actor }}"
           git config --global user.email "${{ github.actor }}@users.noreply.github.com"
 
-      - name: Install packages with yarn
+      - name: Install packages with pnpm
         working-directory: ui
-        run: yarn install
+        run: pnpm install
 
       - name: Build Packages
         working-directory: ui
-        run: yarn build
+        run: pnpm run build
 
       - name: Bump versions and publish packages
         working-directory: ui
-        run: yarn publish:ci
+        run: pnpm run publish:ci
         env:
           GH_TOKEN: ${{ secrets.GH_PAT_UI }}
diff --git a/.github/workflows/ui.yml b/.github/workflows/ui.yml
@@ -17,6 +17,10 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.event.number || github.ref }}
   cancel-in-progress: true
 
+env:
+  # renovate: datasource=npm depName=pnpm versioning=npm
+  PNPM_VERSION: '9.0.6'
+
 jobs:
   skip-check:
     name: Skip check
@@ -50,27 +54,31 @@ jobs:
     steps:
       - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
 
+      - uses: pnpm/action-setup@a3252b78c470c02df07e9d59298aecedc3ccdd6d # v3.0.0
+        with:
+          version: ${{ env.PNPM_VERSION }}
+
       - name: Set up Node.js
         uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3.8.2
         with:
           node-version-file: .node-version
-          cache: 'yarn'
-          cache-dependency-path: ui/yarn.lock
+          cache: 'pnpm'
+          cache-dependency-path: ui/pnpm-lock.yaml
 
       - name: Install project dependencies
-        run: yarn install --frozen-lockfile --prefer-offline
+        run: pnpm install --frozen-lockfile --prefer-offline
         working-directory: ui
 
-      - run: yarn build
+      - run: pnpm run build
         working-directory: ui
 
-      - run: yarn test
+      - run: pnpm run test
         working-directory: ui
 
-      - name: Run ESLint
+      - name: Check typing
         working-directory: ui
-        run: yarn run lint
+        run: pnpm run type-check
 
-      - name: Check typing
+      - name: Run ESLint
         working-directory: ui
-        run: yarn run type-check
+        run: pnpm run lint
diff --git a/Dockerfile.dev b/Dockerfile.dev
@@ -5,16 +5,16 @@ WORKDIR /app
 
 COPY ui/packages/shared ./packages/shared
 COPY ui/packages/app/web/package.json ./packages/app/web/package.json
-COPY ui/package.json ui/yarn.lock ./
-RUN yarn workspace @parca/web install --frozen-lockfile --prefer-offline
+COPY ui/package.json ui/pnpm-lock.yaml ./
+RUN pnpm --filter @parca/web install --frozen-lockfile --prefer-offline
 
 FROM docker.io/node:16.20.2-alpine@sha256:a1f9d027912b58a7c75be7716c97cfbc6d3099f3a97ed84aa490be9dee20e787 AS ui-builder
 
 WORKDIR /app
 
 COPY ui .
 COPY --from=ui-deps /app/node_modules ./node_modules
-RUN yarn install --frozen-lockfile --prefer-offline && yarn build
+RUN pnpm install --frozen-lockfile --prefer-offline && pnpm run build
 
 FROM docker.io/golang:1.22.2-alpine@sha256:cdc86d9f363e8786845bea2040312b4efa321b828acdeb26f393faa864d887b0 AS builder