Merge pull request #257 from parca-dev/fix-autocomplete-space-exception

ui: Fix autocomplete space after comma
parca-dev · Oct 7, 2021 · ea47d4c · ea47d4c
2 parents a202c65 + 82eaf8a
commit ea47d4c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/ui/packages/shared/parser/src/index.test.ts b/ui/packages/shared/parser/src/index.test.ts
@@ -160,3 +160,10 @@ test('SuggestNextLabelName', () => {
     typeahead: ''
   }])
 })
+
+test('SuggestNextLabelNameSpace', () => {
+  expect(Query.suggest('test{test="a", ')).toMatchObject([{
+    type: 'labelName',
+    typeahead: ''
+  }])
+})
diff --git a/ui/packages/shared/parser/src/index.ts b/ui/packages/shared/parser/src/index.ts
@@ -92,7 +92,7 @@ export class Query {
 
     // Parser.table is not defined in the type definitions, so we need to do this unfortunately.
     const parserTable = p.table as any[]
-    const column = parserTable.filter(c => c.states.find(s => s.data !== undefined && Object.prototype.hasOwnProperty.call(s.data, 'profileName')))[0]
+    const column = parserTable.filter(c => c.states.find(s => s.data !== undefined && s.data != null && Object.prototype.hasOwnProperty.call(s.data, 'profileName')))[0]
     if (column !== undefined) {
       const data = column.states.find(s => s.data !== undefined && Object.prototype.hasOwnProperty.call(s.data, 'profileName')).data
       const rest = input.slice(column.lexerState.col - 2)