Skip to content

Commit

Permalink
Merge pull request #3565 from parca-dev/slice-copy
Browse files Browse the repository at this point in the history
pkg/query: Replace remaining slices.Clone
  • Loading branch information
brancz authored Aug 7, 2023
2 parents b1ee3cd + 98bae34 commit f48749b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/query/flamegraph_arrow.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import (
"github.com/polarsignals/frostdb/pqarrow/builder"
"go.opentelemetry.io/otel/trace"
"golang.org/x/exp/maps"
"golang.org/x/exp/slices"

queryv1alpha1 "github.com/parca-dev/parca/gen/proto/go/parca/query/v1alpha1"
"github.com/parca-dev/parca/pkg/profile"
Expand Down Expand Up @@ -351,7 +350,7 @@ func generateFlamegraphArrowRecord(ctx context.Context, mem memory.Allocator, tr
fb.builderCumulative.Add(cr, r.Value.Value(i))
// Continue with this row as the parent for the next iteration and compare to its children.
fb.parent.Set(cr)
compareRows = slices.Clone(fb.children[cr])
compareRows = copyChildren(fb.children[cr])
continue stacktraces
}
// reset the compare rows
Expand Down

0 comments on commit f48749b

Please sign in to comment.