Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Suggestion list scrolls with active suggestion #2164

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

manojVivek
Copy link
Contributor

@manojVivek manojVivek commented Nov 22, 2022

Fixes #2155

Screen.Recording.2022-11-22.at.10.45.30.AM.mov

@manojVivek manojVivek requested a review from a team as a code owner November 22, 2022 05:15
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@brancz brancz merged commit b9b5608 into main Nov 22, 2022
@brancz brancz deleted the suggestion-list-improvement branch November 22, 2022 07:22
fabxc pushed a commit to fabxc/parca that referenced this pull request Dec 5, 2022
* Suggestion list scrolls with active suggestion

* Lint error fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query Builder: Suggestions contains scrolls with the active suggestion
2 participants