pkg/parcacol: Improve sparse labelset ingestion #2201
Merged
+26
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is especially important when request with various series exist where some series might not have labels in their labelset, however the overall buffer written to storage has these label names available as column.
brancz
reviewed
Nov 30, 2022
brancz
approved these changes
Nov 30, 2022
I stopped converting labels.Labels to map[string]string in the separateNameFromLabels. It seem like a good abstraction there still.
metalmatze
force-pushed
the
storage-labelnames
branch
from
0400ff6
to
544767b
Compare
fabxc
pushed a commit
to fabxc/parca
that referenced
this pull request
Dec 5, 2022
* pkg/parcacol: Pass labelset names to consistently ingest labels This is especially important when request with various series exist where some series might not have labels in their labelset, however the overall buffer written to storage has these label names available as column. * pkg: Pass labelset as map[string]string for quicker access I stopped converting labels.Labels to map[string]string in the separateNameFromLabels. It seem like a good abstraction there still.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially important when requests with various series exist where some series might not have labels in their labelset, however, the overall buffer written to storage has these label names available as column.