Use scrape interval correctly #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
We just need you to sign the CLA (it's really just a one-time DCO), then this lgtm! Thank you! |
|
Looks like we have a test that also needs to be adapted. |
|
Will sign the CLA as soon as I've internal confirmation. |
maxbrunet
reviewed
Dec 5, 2022
kakkoyun
approved these changes
Dec 6, 2022
Use the scrape interval rather than the timeout to determine the profile duration on scraping. Since taking the profile will take strictly longer than the duration the timeout must be allowed to be larger as well. By default 3s are added to the interval based on real-world obvservations.
|
@fabxc is attempting to deploy a commit to the parca-dev Team on Vercel. A member of the Team first needs to authorize it. |
|
Signed! |
|
Awesome! 🎉 I started CI. |
|
@all-contributors Please add @fabxc for code. |
|
I've put up a pull request to add @fabxc! 🎉 |
teleivo
added a commit
to teleivo/parca-docs
that referenced
this pull request
Feb 24, 2023
to adapt to changes made in parca-dev/parca#2220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the scrape interval rather than the timeout to determine the profile duration on scraping. Since taking the profile will take strictly longer than the duration the timeout must be allowed to be larger as well. By default 3s are added to the interval based on real-world obvservations.