symbolizer: Log addresses in hexadecimal #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Javier Honduvilla Coto <javierhonduco@gmail.com>
kakkoyun
approved these changes
Dec 6, 2022
maxbrunet
reviewed
Dec 6, 2022
| @@ -57,7 +57,7 @@ func (dl *DwarfLiner) PCToLines(addr uint64) (lines []profile.LocationLine, err | |||
|
|
|||
| lines, err = dl.dbgFile.SourceLines(addr) | |||
| if err != nil { | |||
| level.Debug(dl.logger).Log("msg", "failed to symbolize location", "addr", addr, "err", err) | |||
| level.Debug(dl.logger).Log("msg", "failed to symbolize location", "addr", fmt.Sprintf("0x%x", addr), "err", err) | |||
There was a problem hiding this comment.
FYI the format %#x adds the 0x
Suggested change
| level.Debug(dl.logger).Log("msg", "failed to symbolize location", "addr", fmt.Sprintf("0x%x", addr), "err", err) | |
| level.Debug(dl.logger).Log("msg", "failed to symbolize location", "addr", fmt.Sprintf("%#x", addr), "err", err) |
There was a problem hiding this comment.
TIL!! I think I won't change it because I find it a tiny bit less obvious. It's quite cool though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while taking a look at #1757 (comment)
Signed-off-by: Francisco Javier Honduvilla Coto javierhonduco@gmail.com