pkg/parca: Add e2e test for Go PGO #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalmatze
approved these changes
Feb 9, 2023
kakkoyun
approved these changes
Feb 9, 2023
brancz
force-pushed
the
pgo-e2e-test
branch
2 times, most recently
from
49c1d96
to
7532322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to ensure that the data exported by Parca can be used by Go's newly added profile-guided optimizations (PGO).
While testing this I realized that the functionality currently expects the samples count to be on index position 1 (understandable since that's where the runtime-generated profiles have it). But Parca takes the profiles apart and only returns a single sample type, therefore it currently panics, which is why this patch includes the small fix for the pprof profile. An issue has already been filed upstream: golang/go#58292