fix "Add panel" and visualization type selectors #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicawoj
commented
Mar 15, 2023
| </div> | ||
| <Listbox value={selectedKey} onChange={onSelection}> | ||
| {({open}) => ( | ||
| <div className="min-w-fit relative"> |
There was a problem hiding this comment.
Other than cosmetic changes introduced to the code (for example, removing React fragment elements <></> where not necessary) this is the only significant change introduced in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a 'relative' class to the outer 'div' element holding the select button and options should fix the absolute positioning issue that was taking place on scroll.