Trim flame graph nodes relative to node's parent #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably a good follow-up. We show the percentage of trimmed values. However, with these changes, they are often below 1%. I've seen trimmed values make up from |
metalmatze
force-pushed
the
trim-parent-relative
branch
from
1950f68
to
8d577e3
Compare
So far we have trimmed nodes based on the absolute cumulative value. This is not what we want to do, given we might lose data when diving further into a flame graph. However, in relation to the parent's cumulative value, there may occasion where the direct child still has to few values and would never be rendered. Those we want to trim.
metalmatze
force-pushed
the
trim-parent-relative
branch
from
1a2c455
to
eb2a542
Compare
brancz
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we have trimmed nodes based on the flame graph's absolute cumulative value. This is not what we want to do, given we might lose data when diving further into a flame graph.
However, in relation to the parent's cumulative value, there may occasion where the direct child still has too few values and would never be rendered. Those we want to trim.
cc @manojVivek @brancz