Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/debuginfod: Fix caching and follow redirects of debuginfod servers #2847

Merged
merged 1 commit into from
Mar 25, 2023
Merged

pkg/debuginfod: Fix caching and follow redirects of debuginfod servers #2847

merged 1 commit into from
Mar 25, 2023

Conversation

brancz
Copy link
Member

@brancz brancz commented Mar 24, 2023

This patch does two main things aside from a small cleanup and simplification:

  • Fix caching: Previously while we wrote debuginfo to the object storage cache, we never tried to read if from there in the future.
  • Follow redirects if an upstream debuginfod server returns a HTTP 3xx response.

Fixes #2240

@brancz brancz requested a review from a team as a code owner March 24, 2023 13:33
kakkoyun
kakkoyun approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️ 💚 💙 💛 💜

@kakkoyun kakkoyun merged commit 7954e71 into main Mar 25, 2023
@kakkoyun kakkoyun deleted the debuginfod-redirects branch March 25, 2023 08:47
@brancz brancz mentioned this pull request Apr 4, 2023
Closed
@brancz brancz mentioned this pull request Oct 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debuginfod cache stores, but doesn't read from cache
2 participants
@brancz @kakkoyun