Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/storage: Calculate series' numSamples after truncation #293

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

metalmatze
Copy link
Member

Once Parca truncated the chunks of a series it needs to update the numSamples for consistency when querying.

Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uff, great find! lgtm

@brancz brancz merged commit 57f5917 into release-0.1 Oct 12, 2021
@brancz brancz deleted the truncate-numsamples branch October 12, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants