ui/shared/profile/IcicleGraphArrow: Create arrow-based IcicleGraph #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalmatze
force-pushed
the
flamegraph-arrow-ui
branch
from
bee4b4d
to
49d7ba2
Compare
metalmatze
force-pushed
the
flamegraph-arrow
branch
from
4da41c6
to
dbf095e
Compare
metalmatze
force-pushed
the
flamegraph-arrow
branch
from
3829fde
to
9efa875
Compare
metalmatze
force-pushed
the
flamegraph-arrow-ui
branch
from
49d7ba2
to
979c4ea
Compare
metalmatze
force-pushed
the
flamegraph-arrow-ui
branch
2 times, most recently
from
2f24d6a
to
fd6853d
Compare
metalmatze
force-pushed
the
flamegraph-arrow-ui
branch
from
26e4705
to
35eb5c8
Compare
yomete
reviewed
Jul 5, 2023
| className="rounded-md border bg-gray-50 px-3 py-2 text-sm shadow-sm focus:border-indigo-500 focus:outline-none focus:ring-1 focus:ring-indigo-500 dark:bg-gray-900" | ||
| onChange={e => setSortBy(e.target.value)} | ||
| > | ||
| <option value="function_name">Function Name</option> |
There was a problem hiding this comment.
Shall we place the select dropdown next to the Reset View button and add a text in front. Like this:
"Reset View" "Sort by: <Select />"
yomete
reviewed
Jul 5, 2023
| @@ -52,7 +53,8 @@ type NavigateFunction = (path: string, queryParams: any, options?: {replace?: bo | |||
|
|
|||
| export interface FlamegraphData { | |||
| loading: boolean; | |||
| data?: Flamegraph; | |||
There was a problem hiding this comment.
We might need to cater for this removed prop for the grafana plugin as that's the reason for the typing error here.
There was a problem hiding this comment.
aah, I see. Let's not rename it then, but only add the table one for now. I think there is a bigger refactoring we should do anyway.
yomete
approved these changes
Jul 5, 2023
metalmatze
force-pushed
the
flamegraph-arrow-ui
branch
from
4c4f174
to
c96c7c9
Compare
|
There are some longer-running CI checks still running, but I would like to get this in before we have another conflict. Happy to follow up with PRs if anything is found. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the frontend changes to read flame graphs from arrow records.
The backend changes are in #3069 which this PR depends on.