debuginfo: Add traces #3396
Merged
debuginfo: Add traces #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
force-pushed
the
opentracing_bridge
branch
from
5ae5714
to
3f63e1c
Compare
kakkoyun
commented
Jul 5, 2023
pkg/parca/parca.go
Outdated
| }) | ||
| httpDebugInfoClient, err := debuginfo.NewHTTPDebuginfodClient(logger, flags.Debuginfod.UpstreamServers, | ||
| &http.Client{ | ||
| Transport: otelhttp.NewTransport( |
There was a problem hiding this comment.
HTTP GET error in the screenshot comes from here.
kakkoyun
commented
Jul 5, 2023
brancz
reviewed
Jul 6, 2023
brancz
reviewed
Jul 6, 2023
kakkoyun
force-pushed
the
opentracing_bridge
branch
from
717706f
to
a116fed
Compare
kakkoyun
force-pushed
the
opentracing_bridge
branch
from
1530396
to
23525ef
Compare
Add OpenTracing Bridge Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
force-pushed
the
opentracing_bridge
branch
from
23525ef
to
26130d6
Compare
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
Test Plan
xref: thanos-io/objstore#61
xref: polarsignals/frostdb#469