Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Arrow Flamegraph shows pprof labels #3460

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Conversation

metalmatze
Copy link
Member

This PR shows pprof labels in Tooltips.

A lot of the code changes are actually refactoring the Tooltip to be independent of its content. The content is now passed into the tooltip as JSX children.

image

Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiiiice

@metalmatze metalmatze merged commit b886210 into main Jul 18, 2023
@metalmatze metalmatze deleted the flamegraph-pprof-labels branch July 18, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants