Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Add missing return #354

Merged
merged 2 commits into from
Oct 21, 2021
Merged

bugfix: Add missing return #354

merged 2 commits into from
Oct 21, 2021

Conversation

kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Oct 21, 2021

Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com

Fixes #352

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@kakkoyun kakkoyun changed the base branch from main to release-0.2 October 21, 2021 14:52
paulfantom added a commit to thaum-xyz/ankhmorpork that referenced this pull request Oct 21, 2021
@paulfantom
Copy link
Contributor

I can confirm this solves panic and crashloop from #352. However there are still issues related to:

evel=error name=parca ts=2021-10-21T16:17:51.512719297Z caller=symbol.go:133 msg="failed to open object file" file=tmp/6b37593545645f4d64516d6749384873313275652f50436f4564574a76523045766b38394f7839677a2f6d3462363741454e54697175644b42416f6b746b2f5a4d594b33534a354d336b4e714d564a38515330/debuginfo start=4194304 limit=9682944 offset=0 err="failed to read DWARF data: unexpected EOF"
level=error name=parca ts=2021-10-21T16:17:51.955104803Z caller=symbolizer.go:59 component=symbolizer msg="symbolization attempt failed" err="5 errors occurred:\n\t* storage symbolization request failed: failed to create liner: failed to read DWARF data: unexpected EOF\n\t* storage symbolization request failed: failed to create liner: failed to initialize liner\n\t* storage symbolization request failed: failed to create liner: failed to read DWARF data: unexpected EOF\n\t* storage symbolization request failed: failed to create liner: failed to initialize liner\n\t* storage symbolization request failed: failed to create liner: failed to initialize liner\n\n"

Should I open a separate issue for those?

@kakkoyun
Copy link
Member Author

@paulfantom This is another known issue. Feel free to open one if we haven't already. Someone might report it through discord.

This is related to a bug in the Go standard library. This is on my list. golang/go#18667

And thanks a lot for already testing it!

@kakkoyun kakkoyun marked this pull request as ready for review October 21, 2021 16:58
@kakkoyun kakkoyun changed the title Add missing return bugfix: Add missing return Oct 21, 2021
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
return nil, err
}
return lnr, nil
return nil, errors.New("cannot create a liner from given object file")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulfantom Some of the errors could be coming from this part as well. They could be gone now.

@kakkoyun kakkoyun merged commit 21f92b2 into release-0.2 Oct 21, 2021
@kakkoyun kakkoyun deleted the fix_cache_put_bug branch October 21, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants