-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Add missing return #354
Conversation
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
I can confirm this solves panic and crashloop from #352. However there are still issues related to:
Should I open a separate issue for those? |
@paulfantom This is another known issue. Feel free to open one if we haven't already. Someone might report it through discord. This is related to a bug in the Go standard library. This is on my list. golang/go#18667 And thanks a lot for already testing it! |
9e2f28f
to
2ff114a
Compare
return nil, err | ||
} | ||
return lnr, nil | ||
return nil, errors.New("cannot create a liner from given object file") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulfantom Some of the errors could be coming from this part as well. They could be gone now.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
Fixes #352