Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/config: Allow configuring to keep only certain sample types #3540

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

brancz
Copy link
Member

@brancz brancz commented Aug 2, 2023

If a config specifies a keep_sample_types allow-list in then scrape config then we'll parse the scraped pprof profile and keep only those samples within a profile that match one of the listed sample types. This is especially useful for cases where users only want to ingest heap profiling data, for which there is no way in the pprof endpoints in Go to ignore other data at collection time.

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Aug 2, 2023

✅ Meticulous spotted zero visual differences across 352 screens tested: view results.

Last updated for commit 6ef40f2. This comment will update as new commits are pushed.

@brancz brancz merged commit 5a4f873 into main Aug 2, 2023
32 checks passed
@brancz brancz deleted the keep-sample-type branch August 2, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants