pkg/query: Use non-generic method to clone children list #3552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorfour
approved these changes
Aug 3, 2023
|
✅ Meticulous spotted zero visual differences across 331 screens tested: view results. Last updated for commit b780bbb. This comment will update as new commits are pushed. |
The generic version is a lot more expensive as it grows the slice one by one, instead of pre-allocating the result size.
brancz
force-pushed
the
non-generic-children-clone
branch
from
babf257 to
b780bbb
Compare
brancz
added a commit
that referenced
this pull request
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic version is a lot more expensive as it grows the slice one by one, instead of pre-allocating the result size.