Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/query/flamegraph_arrow: Properly calculate height #3632

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

metalmatze
Copy link
Member

Previously the height was estimated, but didn't take inlined functions and injected label nodes into account.

@metalmatze metalmatze requested a review from a team as a code owner August 16, 2023 10:52
@metalmatze
Copy link
Member Author

I've also updated Go to 1.21 to use the new max keyword. 🙂

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Aug 16, 2023

✅ Meticulous spotted zero visual differences across 211 screens tested: view results.

Last updated for commit 8d114c8. This comment will update as new commits are pushed.

@metalmatze metalmatze changed the base branch from main to renovate/golang August 16, 2023 11:09
Previously the height was estimated, but didn't take inlined functions and injected label nodes into account.
@metalmatze metalmatze merged commit 43f9c5d into main Aug 17, 2023
31 of 32 checks passed
@metalmatze metalmatze deleted the flamegraph-arrow-height branch August 17, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants