Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move table to using arrow #3659

Merged
merged 11 commits into from
Aug 23, 2023
Merged

Move table to using arrow #3659

merged 11 commits into from
Aug 23, 2023

Conversation

metalmatze
Copy link
Member

@metalmatze metalmatze commented Aug 21, 2023

This creates an arrow-based table that has full parity with the current table implementation.
Overall, this is just the start of the table improvements. There are some low-hanging fruits I want to follow up with after this.

We are now also showing Flat Diff and have the Cumulative Diff column be named that, rather than just Diff.

image

@metalmatze metalmatze requested review from a team as code owners August 21, 2023 17:33
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Aug 21, 2023

✅ Meticulous spotted zero visual differences across 241 screens tested: view results.

Last updated for commit da7d2be. This comment will update as new commits are pushed.

Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor question, otherwise lgtm

pkg/query/table.go Show resolved Hide resolved
@metalmatze metalmatze added this pull request to the merge queue Aug 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2023
@metalmatze metalmatze added this pull request to the merge queue Aug 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2023
@metalmatze metalmatze merged commit 14e0e67 into main Aug 23, 2023
31 of 32 checks passed
@brancz brancz deleted the table-arrow branch August 24, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants