-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move table to using arrow #3659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Meticulous spotted zero visual differences across 241 screens tested: view results. Last updated for commit da7d2be. This comment will update as new commits are pushed. |
metalmatze
force-pushed
the
table-arrow
branch
from
August 22, 2023 17:47
72e76aa
to
fbbcf74
Compare
Also start using the columnsVisibility feature by react-table rather than adding columns manually like before.
metalmatze
force-pushed
the
table-arrow
branch
from
August 23, 2023 15:24
b76d537
to
d342e10
Compare
brancz
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor question, otherwise lgtm
brancz
approved these changes
Aug 23, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 23, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates an arrow-based table that has full parity with the current table implementation.
Overall, this is just the start of the table improvements. There are some low-hanging fruits I want to follow up with after this.
We are now also showing
Flat Diff
and have theCumulative Diff
column be named that, rather than justDiff
.