ui/shared/profile: Pass down arrow response object #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of building the table from the response object right away, pass down the wrapper with additional information, such as trimming value. Only in the final step, right before building the icicle graph, parse the record bytes into an actual arrow table.
|
🤖 Meticulous spotted visual differences in 2 of 339 screens tested: view and approve differences detected. Last updated for commit 196086b. This comment will update as new commits are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of building the table from the response object right away, pass down the wrapper with additional information, such as trimming value.
Only in the final step, right before building the icicle graph, parse the record bytes into an actual arrow table.
Trimmed 7 (0.267%) too small values.shows up with both flame graph report types now.