Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Range picker redesign #4139

Merged
merged 14 commits into from
Nov 27, 2023
Merged

Time Range picker redesign #4139

merged 14 commits into from
Nov 27, 2023

Conversation

monicawoj
Copy link
Contributor

@monicawoj monicawoj commented Nov 21, 2023

Resolves #4024

Implements a new time range picker design to improve UX of quicker choosing or adjusting time range of query. Additionally, in this PR, a new query is run every time the time range changes instead of having to explicitly click “search”

@monicawoj monicawoj marked this pull request as ready for review November 22, 2023 20:44
@monicawoj monicawoj requested a review from a team as a code owner November 22, 2023 20:44
Copy link

alwaysmeticulous bot commented Nov 22, 2023

🤖 Meticulous spotted visual differences in 315 of 404 screens tested: view and approve differences detected.

Last updated for commit 9c5138c. This comment will update as new commits are pushed.

Copy link
Contributor

@yomete yomete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚢🇮🇹

@brancz
Copy link
Member

brancz commented Nov 23, 2023

Loooooooove this!!

A few minor things:

  1. I clicked on the absolute thing while it was 15m, and then on relative again, and it was 6h. That was unexpected.
  2. I typed a different value and hit enter, but that didn't do anything, I think hitting enter should run the query.

@monicawoj
Copy link
Contributor Author

Loooooooove this!!

A few minor things:

  1. I clicked on the absolute thing while it was 15m, and then on relative again, and it was 6h. That was unexpected.
  2. I typed a different value and hit enter, but that didn't do anything, I think hitting enter should run the query.
  1. Yeah current functionality just defaults to 6h when going from absolute to relative. I'll write up a function that calculates the general time range between the absolute date-times and shows that as the relative time.
  2. Yup, currently just clicking out of the input runs the query. Will add an event listener for hitting 'enter'!

Thanks for the input!

@brancz
Copy link
Member

brancz commented Nov 27, 2023

Not sure what's up, but now only the first time hitting enter in the input box works, after that it only triggers when I either use the buttons, or click out of the field. I think hitting enter should already deselect the input field, and only enter should trigger a query, not clicking out of it.

@monicawoj monicawoj merged commit f51f864 into main Nov 27, 2023
37 of 38 checks passed
@monicawoj monicawoj deleted the time-picker-changes branch November 27, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make relative time picker linear
3 participants