-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time Range picker redesign #4139
Conversation
ui/packages/shared/components/src/DateTimeRangePicker/RelativeDatePicker/index.tsx
Fixed
Show fixed
Hide fixed
ui/packages/shared/components/src/DateTimeRangePicker/RelativeDatePicker/index.tsx
Dismissed
Show dismissed
Hide dismissed
🤖 Meticulous spotted visual differences in 315 of 404 screens tested: view and approve differences detected. Last updated for commit 9c5138c. This comment will update as new commits are pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🚢🇮🇹
ui/packages/shared/components/src/DateTimeRangePicker/RelativeDatePicker/index.tsx
Outdated
Show resolved
Hide resolved
Loooooooove this!! A few minor things:
|
Thanks for the input! |
Not sure what's up, but now only the first time hitting enter in the input box works, after that it only triggers when I either use the buttons, or click out of the field. I think hitting enter should already deselect the input field, and only enter should trigger a query, not clicking out of it. |
Resolves #4024
Implements a new time range picker design to improve UX of quicker choosing or adjusting time range of query. Additionally, in this PR, a new query is run every time the time range changes instead of having to explicitly click “search”