Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parca-dev#4262): init logger #4291

Merged
merged 5 commits into from
Feb 1, 2024
Merged

fix(parca-dev#4262): init logger #4291

merged 5 commits into from
Feb 1, 2024

Conversation

dreamerlzl
Copy link
Contributor

BTW, a golangci-linter named exhaustruct can be used to prevent this case.

@dreamerlzl dreamerlzl requested review from a team as code owners January 17, 2024 15:14
@kakkoyun
Copy link
Member

@dreamerlzl Tests seem to fail.

auto-merge was automatically disabled January 18, 2024 15:57

Head branch was pushed to by a user without write access

@dreamerlzl
Copy link
Contributor Author

dreamerlzl commented Jan 18, 2024 •
edited
Loading

@dreamerlzl Tests seem to fail.

Sorry, forgot to modify the tests accordingly.
But I don't see why this data race would happen, since my commits here are quite clear which are only about the logger init: https://github.com/parca-dev/parca/actions/runs/7571938751/job/20620637997

@metalmatze metalmatze merged commit 4c21c4a into parca-dev:main Feb 1, 2024
30 of 34 checks passed
@metalmatze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamerlzl @kakkoyun @metalmatze