Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add week and year to presets in DateTimeRangePicker #4303

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

metalmatze
Copy link
Member

  • ui: Add week and year relative time range to DatePicker
  • ui: Change the timeFormat to yyyy-MM-dd HH:mm:ss

This is the format we have in the AbsoluteDatetimeRangePicker.
It better comparable when looking at multiple dates.
@metalmatze metalmatze requested a review from a team as a code owner February 13, 2024 12:29
Copy link

alwaysmeticulous bot commented Feb 13, 2024

🤖 Meticulous spotted visual differences in 330 of 403 screens tested: view and approve differences detected.

Last updated for commit 4bf1c2b. This comment will update as new commits are pushed.

Copy link
Contributor

@yomete yomete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@metalmatze
Copy link
Member Author

Thank you for the reviews!

@metalmatze metalmatze merged commit ce2f336 into main Feb 13, 2024
33 of 38 checks passed
@metalmatze metalmatze deleted the ui-datetimerangepicker-weekyear branch February 13, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants