Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add a timezone parameter to Parca context #4549

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Conversation

yomete
Copy link
Contributor

@yomete yomete commented Apr 23, 2024

No description provided.

Copy link

alwaysmeticulous bot commented Apr 23, 2024

🤖 Meticulous spotted visual differences in 4 of 424 screens tested: view and approve differences detected.

Last updated for commit 64df65b. This comment will update as new commits are pushed.

@yomete yomete changed the title ui: Add a timezone parameter to Parca context (wip) ui: Add a timezone parameter to Parca context Apr 25, 2024
Comment on lines 9 to +13
- remote: buf.build
owner: grpc-ecosystem
repository: grpc-gateway
commit: 7dec1bb6f79840c5849dac18f642de9c
digest: shake256:aa37e1bbccaf5793f1c82af9e620e67220f390dc5cbab2b8b3091aa4c030f32d9144be4dbfb8a90d02d44cd6b781875959ab1d454742ebd3d586b1a7806a07ea
commit: ca289928665845a7b2f7285d052c739a
digest: shake256:67b115260e12cb2d6c5d5ce8dbbf3a095c86f0e52b84f9dbd16dec9433b218f8694bc9aadb1d45eb6fd52f5a7029977d460e2d58afb3208ab6c680e7b21c80e4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file was added by precommit automatically after my first commit. not sure why this happened.

Copy link
Contributor

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@yomete yomete enabled auto-merge April 25, 2024 12:00
@yomete yomete merged commit 349c1c7 into main Apr 25, 2024
38 checks passed
@yomete yomete deleted the configurable-timezone branch November 7, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants