Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/config: support seconds in pprof configuration #4623

Merged
merged 5 commits into from
Jun 4, 2024

Commits on Jun 3, 2024

  1. pkg/config: support seconds in pprof configuration

    this updates the definition of `PprofProfilingConfig` such that a new
    integer field `Seconds` is added which can be set for profiles.
    
    additionally, it changes the behavior where setting any profiling
    configurations will end up overriding the default so merge will now
    become a replace.
    
    seconds is accepted as a query parameter and with this change, when
    provided, it will be used as scraping duration rather than the scraping
    interval value. this allows having scraping where process being profiled
    isn't under constant profiling. this only applies to configurations that
    have delta enabled.
    
    https://pkg.go.dev/net/http/pprof
    alperkokmen committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    d9994cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38a4688 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8e7f9ab View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    30229ab View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. fix goimports -local

    alperkokmen committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c37229c View commit details
    Browse the repository at this point in the history