ui: Make handling of selections more robust #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 75 of 361 screens tested: view and approve differences detected. Last updated for commit b3bb6ff. This comment will update as new commits are pushed. |
brancz
force-pushed
the
robust-label-handling
branch
from
3a3b858
to
5e5c701
Compare
brancz
force-pushed
the
robust-label-handling
branch
from
5e5c701
to
11a8b93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overhauls how we do selections. Since we always perform "merge" selections now this could be significantly simplified and now everything uses the parser as opposed to saving the profile name and labels separately in the URL.