Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Configuring step count as a derivative of screen size such that there are 10px gap per point #4847

Merged
merged 2 commits into from
Jul 5, 2024
Merged

ui: Configuring step count as a derivative of screen size such that there are 10px gap per point #4847

merged 2 commits into from
Jul 5, 2024

Conversation

manojVivek
Copy link
Contributor

No description provided.

@manojVivek manojVivek requested a review from a team as a code owner July 4, 2024 10:43
@alwaysmeticulous alwaysmeticulous
Copy link

alwaysmeticulous bot commented Jul 4, 2024 •
edited
Loading

🤖 Meticulous spotted visual differences in 74 of 498 screens tested: view and approve differences detected.

Last updated for commit 17f6f47. This comment will update as new commits are pushed.

metalmatze
metalmatze approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I'm very curious if this is going to make a difference when using it for longer.

yomete
yomete approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@yomete yomete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@manojVivek manojVivek merged commit 43531b8 into main Jul 5, 2024
38 checks passed
@manojVivek manojVivek deleted the metrics-graph-fewer-datapoints branch July 5, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalmatze metalmatze metalmatze approved these changes

@yomete yomete yomete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manojVivek @metalmatze @yomete