Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump phf dependency in parcel_selectors crate #442

Merged

Conversation

nicoburns
Copy link
Contributor

@nicoburns nicoburns commented Mar 11, 2023

Context

We're wanting to use lightningcss as a dependency in Taffy. However our CI is complaining that lightningcss is depending on multiple versions of the same crate (which we try to avoid for binary size reasons).

I've tracked this down to parcel_selectors crate which depends on phf 0.8on cssparser 0.29 which depends on phf 0.10.

Changes made

  • Updates the parcel_selectors crate to use phf 0.10 (no code changes needed)
  • Bumps the version of the parcel_selectors crate to from 0.25.1 to 0.25.2
  • Updates the repository field of Cargo.toml to point to this repo
  • Updates the documentatation field of Cargo.toml to point to docs for the parcel_selectors crate rather than the selectors crate.

@nicoburns nicoburns changed the title Bump phf dep in selectors crate Bump phf dependency in parcel_selectors crate Mar 12, 2023
Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@devongovett devongovett merged commit f4e6de1 into parcel-bundler:master Apr 7, 2023
@nicoburns
Copy link
Contributor Author

@devongovett Thanks for merging this. Would it be possible to publish the new version of the parcel_selectors crate containing this fix? I think that's all the should be required as it's a semver compatible release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants