Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: size prop can't order corretly. #838

Closed

Conversation

GiveMe-A-Name
Copy link

@GiveMe-A-Name GiveMe-A-Name commented Oct 17, 2024

Example

.foo { 
   height: auto; 
   height: calc(100vh - var(--header-height, 0rem)); 
}

After lightningcss minify, css code would like this

.foo { 
   height: calc(100vh - var(--header-height, 0rem)); 
   height: auto; 
}

But it's not expect.
we can maintain the last prop, then delete the repeat prop. Like bellow:

.foo { 
   height: calc(100vh - var(--header-height, 0rem)); 
}

fix: #805

@sbyps
Copy link

sbyps commented Oct 19, 2024

anyone can review this PR? @devongovett

@devongovett
Copy link
Member

devongovett commented Nov 3, 2024

One problem with this approach is that it assumes that all unparsed properties are valid and supported by all browser targets. Unparsed properties may be things other than values containing variables. Say CSS adds a new unit that lightningcss doesn't support yet. This will result in an unparsed property value, which means we may need to preserve multiple values for unparsed properties.

.foo {
  width: 200px;
  width: 200abc;
  width: some-keyword;
}

If some-keyword and 200abc aren't supported by all browsers, they'll fall back to 200px. In this case we need to preserve all property values. A real-world example is the new calc-size() function that lightningcss does not yet parse, but that is supported in Chrome.

I think we can do a better job of deduplicating values that are exactly the same, or values that contain var(), but that is a much bigger task that should apply across all properties. For now, I'm just going to fix the immediate bug which is that we don't flush the current values when we hit an unparsed property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]lighting css will shuffle css properties order
3 participants