-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Default to Dart-Sass and add backwards compatibility for node-sass (#…
…1847) Dart sass will prevent parcel from randomly freezing. It's also a lot stricter, preventing unknown errors or side-effects after compiling/parsing. Also adds codeFrames, so users get a visual representation of the line the error occurs. Closes #1836 Related to #1509
- Loading branch information
1 parent
c4dc892
commit 571ca9d
Showing
7 changed files
with
138 additions
and
434 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/core/parcel/test/integration/sass-advanced-import/bar.sass
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
.bar | ||
color: green; | ||
color: green |
2 changes: 1 addition & 1 deletion
2
packages/core/parcel/test/integration/sass-advanced-import/foo.sass
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
.foo | ||
color: blue; | ||
color: blue |
8 changes: 4 additions & 4 deletions
8
packages/core/parcel/test/integration/sass-advanced-import/index.sass
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
@import '~/foo'; | ||
@import '~/bar.sass'; | ||
@import "~/foo" | ||
@import "~/bar.sass" | ||
|
||
.index | ||
background: #ffffff; | ||
color: #000000; | ||
background: #ffffff | ||
color: #000000 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.