Resolve Dependency correctly if the target asset is URI-encoded (#401)

* Resolve Dependency correctly if the target asset is URI-encoded * Resolve Dependency correctly if the target asset is URI-encoded * revert decodeURIComponent * Resolve Dependency correctry if the target asset is URI-encoded * add a test code
parcel-bundler · Jan 6, 2018 · 9770acf · 9770acf
1 parent 4e2ecc3
commit 9770acf
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 1 deletion.
diff --git a/src/assets/HTMLAsset.js b/src/assets/HTMLAsset.js
@@ -47,7 +47,7 @@ class HTMLAsset extends Asset {
  continue;
  }
  if (elements && elements.includes(node.tag)) {
- let assetPath = this.addURLDependency(node.attrs[attr]);
+ let assetPath = this.addURLDependency(decodeURIComponent(node.attrs[attr]));
  if (!isURL(assetPath)) {
  assetPath = urlJoin(this.options.publicURL, assetPath);
  }

diff --git a/test/encodedURI.js b/test/encodedURI.js
@@ -0,0 +1,29 @@
+const assert = require('assert');
+const fs = require('fs');
+const {bundle, assertBundleTree} = require('./utils');
+
+describe('encodedURI', function() {
+ it('should support bundling files which names in encoded URI', async function() {
+ let b = await bundle(__dirname + '/integration/encodedURI/index.html');
+
+ assertBundleTree(b, {
+ name: 'index.html',
+ assets: ['index.html'],
+ childBundles: [
+ {
+ type: 'jpg',
+ assets: ['日本語.jpg'],
+ childBundles: []
+ }
+ ]
+ });
+
+ let files = fs.readdirSync(__dirname + '/dist');
+ let html = fs.readFileSync(__dirname + '/dist/index.html');
+ for (let file of files) {
+ if (file !== 'index.html') {
+ assert(html.includes(file));
+ }
+ }
+ });
+});
diff --git a/test/integration/encodedURI/index.html b/test/integration/encodedURI/index.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+ <head>
+ <meta charset="utf-8" />
+ <title>Parcel encoded-URI testing</title>
+ </head>
+ <body>
+ <H1>Parcel encoded-URI testing</H1>
+ <img alt="日本語" src="%e6%97%a5%e6%9c%ac%e8%aa%9e.jpg" />
+ </body>
+</html>
diff --git a/test/integration/encodedURI/日本語.jpg b/test/integration/encodedURI/日本語.jpg