Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would like a more helpful error message in the case of empty <meta> strings #1714

Closed
CharlesWiltgen opened this issue Jul 12, 2018 · 0 comments · Fixed by #2027
Closed

Would like a more helpful error message in the case of empty <meta> strings #1714

CharlesWiltgen opened this issue Jul 12, 2018 · 0 comments · Fixed by #2027
Labels
🐛 Bug

Comments

@CharlesWiltgen
Copy link

CharlesWiltgen commented Jul 12, 2018 •
edited
Loading

🐛 Bug report

I'm a new user, and in the course of migrating a working project to Parcel was confused by an error message for an otherwise-valid tag.

<head>
    <meta name="twitter:image" content="" />
</head>

🤔 Expected Behavior

Ideally, Parcel either wouldn't error out on empty strings in <meta> tags, or would emit a more helpful error if Parcel is unable to work with it.

😯 Current Behavior

Received error message: "The 'path' argument must be of type string. Received type object"

🙏Thank you!
hiroppy added a commit to hiroppy/parcel that referenced this issue Sep 18, 2018
@hiroppy
allow empty string in meta
e8dec9b 
fixes parcel-bundler#1714
@hiroppy hiroppy mentioned this issue Sep 18, 2018
Merged
3 tasks
DeMoorJasper pushed a commit that referenced this issue Sep 18, 2018
@hiroppy @DeMoorJasper
allow empty string in meta (#2027)
a50222a 
fixes #1714
devongovett pushed a commit that referenced this issue Oct 15, 2018
@hiroppy @DeMoorJasper
allow empty string in meta (#2027)
f6e1f76 
fixes #1714
devongovett pushed a commit that referenced this issue Oct 15, 2018
@hiroppy @DeMoorJasper
allow empty string in meta (#2027)
74fe47b 
fixes #1714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow empty string in meta hiroppy/parcel
2 participants
@DeMoorJasper @CharlesWiltgen