Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into problems using code splitting, and eventually discovered it was because of a bug in LazyPromise.
If you have code like this:
Then I would expect the the file would log both
'1'
and'2'
. Before this fix, it logs only '1
', because if the promise executor has already been invoked, thenLazyPromise.prototype.then
is a no-op, just returning the existing promise.The fix is to always invoke the appropriate callback, even if the promise has already been executed.
I ran into this issue when doing code splitting because I wanted to eagerly, but asynchronously load a dependency, and then use it later. I suspect this problem will also occur in any situation where a dynamic
import()
is used in multiple places in a single file.