Give priority to styl files in StylusAsset resolver #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeMoorJasper
approved these changes
Apr 2, 2018
devongovett
reviewed
Apr 6, 2018
src/assets/StylusAsset.js
Outdated
| const resolver = new Resolver(asset.options); | ||
| const resolver = new Resolver( | ||
| Object.assign({}, asset.options, { | ||
| extensions: getResolverExtensions(asset.options) |
There was a problem hiding this comment.
maybe we should just hard-code the extensions supports importing? ['.styl', '.css'] - currently it's not possible to e.g. import a .less file from stylus anyway. WDYT?
|
@devongovett Thanks for wrapping this up, been traveling without PC! |
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stylus's base case expects a
.stylfile. If a folder has two or more files with the same name, but different extensions, anystylfile should take precedence for the sake of resolution. This sortsstylto the top of the list so that it is checked first.Closes #1110