Fix reference pass error in package config #1149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Bugfix
Tests
All tests are passing
Description
We will get an error config if we loading config multiple times from
package.json
, because the config is passed by reference.For example, we use
postcss
and add apostcss
field intopackage.json
like this:Then the first time in
./src/transforms/postcss.js:L34
we can get a correct config like above.But if we change some styles, in the second time we will get an error config like this:
All
plugins
will missing because it has been overwritten in./src/transforms/postcss.js:L48
, then compiling will break.