Fix serving files with query params #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm looking forward to this release |
|
@travcunn it has already been released in 1.7.1, together with a bunch of other bug fixes |
|
@devongovett While this is working for query params, it still happens when part of a URL path contains a dot. I'm running into this with a SPA that passes an encoded URI component that contains a dot in the path. Eg. http://localhost:1234/test.string I started a new issue for this. |
devongovett
added a commit
that referenced
this pull request
Oct 15, 2018
devongovett
added a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If query params containing a dot character were on a request to
/, they would get treated as the file extension. This parses the pathname from the requested URL and matches the extname against that instead. Fixes #1164.